Add lint.xml and add ignores to it #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more expandable later on this way.
Luna712
changed the title
Contributor
Author
|
@fire-light42 this should be a fairly easy merge (#2301 also probably), sorry for the ping but trying to get some of my old PRs merged as my setup is getting hard to maintain so trying to get some past PRs merged so ai can clean it up. If there are issues though that's fine it can still wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more expandable later on this way. Disabling
ByteOrderMarkis also the very last lint error, then once that and #2273, which also fixes the only instance ofImpliedQuantitylint error is merged, all lint errors will be fixed and we can enablefailOnErrorto prevent potential future issues like #2320. I think #2301 also needs merged though as it fixes error level lint errors in library (well actually it fixes all lint levels in library), but I don't think that has any affect since before using the new KMP plugin it only checks android-only classes which has no lint issues now anyway.